fix(retain): clarify fact type boundary for user rules#2440
Merged
nicoloboschi merged 2 commits intoJun 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
User preferences, rules, corrections, and constraints can be stated during assistant interactions, but they are durable facts about the user rather than assistant experiences. The current fact extraction guidance made that boundary easy to blur, which can send durable user facts through the experience path.
Fixes #2437.
Fix
worldeven when mentioned in an assistant interaction.assistantto actions or experiences the assistant/agent actually performed.Test
uv run pytest tests/test_fact_extraction_fact_type_prompt.py -quv run ruff check hindsight_api/engine/retain/fact_extraction.py tests/test_fact_extraction_fact_type_prompt.pyuv run ruff format --check hindsight_api/engine/retain/fact_extraction.py tests/test_fact_extraction_fact_type_prompt.pygit diff --checkRisk
Low-to-medium. This is prompt/schema guidance only, not persistence or mapping logic. It should reduce misclassification of user facts, but prompt wording can affect extraction behavior, so the change is intentionally narrow.